-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow publishing cloud events directly #868
Conversation
Signed-off-by: Sun Zhongfeng <suraciii@outlook.com>
7e09265
to
7125a03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR! Overall, everything looks good. One thing I think it'd be good to investigate is to see if we can mimic the tests here:
Using the updated client. Can you look into that and see if there's value there?
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
+ Coverage 69.13% 69.16% +0.03%
==========================================
Files 142 143 +1
Lines 4649 4657 +8
Branches 517 520 +3
==========================================
+ Hits 3214 3221 +7
Misses 1318 1318
- Partials 117 118 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@halspang Thanks for your review. I think events published by dapr client are encapsulated by dapr runtime, so tests on Please correct me if I have misunderstood that. |
Can this RP be merged? This function is required |
Description
Please explain the changes you've made
Allow users to publish cloud events directly, so that users can specify attributes (types, subjects, etc), which are useful for events routing.
This PR added two types,
CloudEvent
andCloudEvent<TData>
.Usage:
The result message content in kafka:
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
#773
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: